netdev - Re: [PATCH 12/14] [rndis_host] Add RNDIS physical medium checking into generic_rndis

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200801270829.53470.david-b@pacbell.net>
Date:	Sun, 27 Jan 2008 08:29:53 -0800
From:	David Brownell <david-b@...bell.net>
To:	Jussi Kivilinna <jussi.kivilinna@...et.fi>
Cc:	linux-wireless@...r.kernel.org, netdev@...r.kernel.org,
	bjd@...z.net
Subject: Re: [PATCH 12/14] [rndis_host] Add RNDIS physical medium checking into generic_rndis_bind()

On Friday 25 January 2008, Jussi Kivilinna wrote:
> +       if(flags & FLAG_RNDIS_PHYM_WIRELESS &&
> +                       *phym != RNDIS_PHYSICAL_MEDIUM_WIRELESS_LAN) {
> +               dev_err(&intf->dev, "driver requires wireless physical "
> +                                       "medium, but device is not.\n");
> +               retval = -ENODEV;
> +               goto halt_fail_and_release;
> +       }
> +       if(flags & FLAG_RNDIS_PHYM_NOT_WIRELESS &&
> +                       *phym == RNDIS_PHYSICAL_MEDIUM_WIRELESS_LAN) {
> +               dev_err(&intf->dev, "driver requires non-wireless physical "
> +                                       "medium, but device is wireless.\n");
> +               retval = -ENODEV;

Well, other than the obvious checkpatch.pl warnings waiting to trigger
("if" is not a function; put a space before the paren) and what I'd call
missing parens around the "flags & ...", those are *not* errors.  No
wonder you thought this would cause too many messages!!

Just make those be dev_dbg() calls instead.  The strongest message level
you can argue for there would be KERN_NOTICE, "normal but significant";
except it's not especially significant.  Filtering by netif_msg_probe()
may be a good idea too; that's normally enabled in this framework.

- Dave

p.s. Before these get submitted, *all* of them need to pass "checkpatch.pl".
  Ideally, "checkpatch.pl --strict" ...

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html