netdev - Re: [PATCH 12/14] [rndis_host] Add RNDIS physical medium checking into generic_rndis

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1201460746.3663.18.camel@localhost>
Date:	Sun, 27 Jan 2008 21:05:46 +0200
From:	Jussi Kivilinna <jussi.kivilinna@...et.fi>
To:	David Brownell <david-b@...bell.net>
Cc:	linux-wireless@...r.kernel.org, netdev@...r.kernel.org,
	bjd@...z.net
Subject: Re: [PATCH 12/14] [rndis_host] Add RNDIS physical medium checking
	into generic_rndis_bind()

On Sun, 2008-01-27 at 08:29 -0800, David Brownell wrote:
> Well, other than the obvious checkpatch.pl warnings waiting to trigger
> ("if" is not a function; put a space before the paren) and what I'd call
> missing parens around the "flags & ...", those are *not* errors.  No
> wonder you thought this would cause too many messages!!
Well, I guess I got lazy between patchsets. 

> Just make those be dev_dbg() calls instead.  The strongest message level
> you can argue for there would be KERN_NOTICE, "normal but significant";
> except it's not especially significant.  Filtering by netif_msg_probe()
> may be a good idea too; that's normally enabled in this framework.
I'll use dev_dbg() with netif_msg_probe().

> p.s. Before these get submitted, *all* of them need to pass "checkpatch.pl".
>   Ideally, "checkpatch.pl --strict" ...
Ok, I'll remember that now.

I'm not very familiar with posting patches (as some might have noticed)
so I have some questions.. if you don't mind. Now that you have acked
most of the patches, is it ok for me to add your 'Acked-by' to those
patches? Should I even repost all of these patches as patchset or just
ones that have been fixed? Should I post new 'physical medium' patch as
reply to this post and then repost patchset with your ack just to
mailing list?

 - Jussi Kivilinna

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html