netdev - [PATCH] SCTP: Fix miss of report unrecognized HMAC Algorithm parameter

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <479D18AF.7000802@cn.fujitsu.com>
Date:	Mon, 28 Jan 2008 08:50:07 +0900
From:	Wei Yongjun <yjwei@...fujitsu.com>
To:	netdev@...r.kernel.org
Cc:	lksctp-developers@...ts.sourceforge.net,
	David Miller <davem@...emloft.net>
Subject: [PATCH] SCTP: Fix miss of report unrecognized HMAC Algorithm parameter

This patch fix miss of check for report unrecognized HMAC Algorithm 
parameter.
When AUTH is disabled, goto fall through path to report unrecognized 
parameter, else, just break.
> Wei
>
> Neil Horman wrote:
>> On Wed, Jan 23, 2008 at 09:30:27AM +0900, Wei Yongjun wrote:
>>> This patch fix miss of check for report unrecognized HMAC Algorithm 
>>> parameter.
>>> When AUTH is disabled, goto fall through path to report unrecognized 
>>> parameter, else, just break.
>>>
>>>
>>
>> Acked-by: Neil Horman <nhorman@...driver.com>
>>
>> Neil
>>
>
> Can you please send this to netdev and CC Dave Miller..
>
> Acked-by: Vlad Yasevich <vladislav.yasevich@...com>
>
> -vlad
Signed-off-by: Wei Yongjun <yjwei@...fujitsu.com>
Acked-by: Neil Horman <nhorman@...driver.com>
Acked-by: Vlad Yasevich <vladislav.yasevich@...com>


--- a/net/sctp/sm_make_chunk.c	2008-01-21 00:03:25.000000000 -0500
+++ b/net/sctp/sm_make_chunk.c	2008-01-21 02:33:36.000000000 -0500
@@ -2014,7 +2014,7 @@ static sctp_ierror_t sctp_verify_param(c
 		break;
 
 	case SCTP_PARAM_HMAC_ALGO:
-		if (!sctp_auth_enable)
+		if (sctp_auth_enable)
 			break;
 		/* Fall Through */
 fallthrough:


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html