netdev - Re: [PATCH] bfin_mac: Make the MDIO polling faster

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <1201628875.26902.14.camel@roc-laptop>
Date:	Wed, 30 Jan 2008 01:47:55 +0800
From:	Bryan Wu <bryan.wu@...log.com>
To:	Kalle Pokki <kalle.pokki@....com>
Cc:	netdev@...r.kernel.org, Bryan Wu <bryan.wu@...log.com>
Subject: Re: [PATCH] bfin_mac: Make the MDIO polling faster


On Tue, 2008-01-29 at 20:28 +0800, Kalle Pokki wrote:
> The poll routine always got 10 ms penalty when called immediately 
> after starting the transfer. The MDIO transfer takes 25.6 us at the 
> noinal 2.5 MHz, so MAX_TIMEOUT_CNT being 500 is still big enough. 

Exactly, but we got a same fixing already.
It will be sent out soon.

Thanks a lot
-Bryan

> --- 
>  drivers/net/bfin_mac.c |    2 +- 
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/net/bfin_mac.c b/drivers/net/bfin_mac.c 
> index c199633..d2e6813 100644 
> --- a/drivers/net/bfin_mac.c 
> +++ b/drivers/net/bfin_mac.c 
> @@ -296,7 +296,7 @@ static void mdio_poll(void) 
>   
>         /* poll the STABUSY bit */ 
>         while ((bfin_read_EMAC_STAADD()) & STABUSY) { 
> -               mdelay(10); 
> +               udelay(1); 
>                 if (timeout_cnt-- < 0) { 
>                         printk(KERN_ERR DRV_NAME 
>                         ": wait MDC/MDIO transaction to complete
> timeout\n"); 
> -- 
> 1.4.4.2
> 
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html