netdev - RE: Lots of "BUG eth1 code -5 qlen 0" messages in 2.6.24

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <D5C1322C3E673F459512FB59E0DDC329046C6E1A@orsmsx414.amr.corp.intel.com>
Date:	Tue, 29 Jan 2008 13:48:47 -0800
From:	"Waskiewicz Jr, Peter P" <peter.p.waskiewicz.jr@...el.com>
To:	<hadi@...erus.ca>
Cc:	"Erik Mouw" <mouw@...linux.org>, <netdev@...r.kernel.org>
Subject: RE: Lots of "BUG eth1 code -5 qlen 0" messages in 2.6.24


> > Are you using any specific qdisc, or just the default pfifo_fast?  
> > Have you done any specific tuning on your qdisc as well?  
> The default 
> > qlen seems to have been changed.
> 
> The driver seems buggy. Make it return NETDEV_TX_BUSY instead 
> of -EIO in xircom_start_xmit() and the messages will go away.

Totally agree.  However, the driver is still getting entries when it
shouldn't (netif_queue_stopped() is true), hence it's returning a non-OK
value.  We can either re-add the check for netif_queue_stopped() to
qdisc_restart(), or update the drivers to use the newer API.  I'd rather
do the latter, which I can work on.

Thanks Jamal!

-PJ
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html