netdev - Re: [PATCH] [NET] cpmac: convert to new Fixed PHY infrastructure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <02FAED2A-1154-4D8B-A245-4693BF283515@kernel.crashing.org>
Date:	Wed, 30 Jan 2008 11:24:54 -0600
From:	Kumar Gala <galak@...nel.crashing.org>
To:	Jeff Garzik <jeff@...zik.org>
Cc:	avorontsov@...mvista.com,
	linuxppc-dev list <linuxppc-dev@...abs.org>,
	netdev@...r.kernel.org, Eugene Konev <ejka@...i.kspu.ru>
Subject: Re: [PATCH] [NET] cpmac: convert to new Fixed PHY infrastructure


On Jan 30, 2008, at 11:09 AM, Jeff Garzik wrote:

> Anton Vorontsov wrote:
>> On Mon, Jan 21, 2008 at 01:19:41PM -0600, Kumar Gala wrote:
>>> Anton,
>>>
>>> it looks like the "TI AR7 CPMAC Ethernet support" uses FIXED_PHY  
>>> and  was selecting FIXED_MII_100_FDX which is gone.
>>>
>>> Can you look into this.  I get the following warning now:
>>>
>>> scripts/kconfig/conf -s arch/powerpc/Kconfig
>>> drivers/net/Kconfig:1713:warning: 'select' used by config symbol   
>>> 'CPMAC' refers to undefined symbol 'FIXED_MII_100_FDX'
>> Wow. I thought there were no Fixed PHY users. :-)
>> Jeff, as you've already Acked Fixed PHY rework to go through powerpc
>> tree, would you please Ack this patch in addition? I hope cpmac
>> maintainer will fix remaining issues as time goes by.
>> Thanks!
>> - - - -
>> From: Anton Vorontsov <avorontsov@...mvista.com>
>> Subject: [PATCH] [NET] cpmac: convert to new Fixed PHY infrastructure
>> This patch converts cpmac to the new Fixed PHY infrastructure,  
>> though it
>> doesn't fix all the problems with that driver. I didn't even bother  
>> to
>> test this patch to compile, because cpmac driver is broken in  
>> several ways:
>> 1. This driver won't compile by itself because lack of its header  
>> describing
>>   platform data;
>> 2. It assumes that fixed PHYs should be created by the ethernet  
>> driver.
>>   It is wrong assumption: fixed PHYs creation is platform code  
>> authority,
>>   driver must blindly accept bus_id and phy_id platform data  
>> variables
>>   instead.
>> Also, it seem that that driver doesn't have actual in-tree users, so
>> nothing to fix further.
>> The main purpose of that patch is to get rid of the following Kconfig
>> warning:
>> scripts/kconfig/conf -s arch/powerpc/Kconfig
>> drivers/net/Kconfig:1713:warning: 'select' used by config symbol
>> 'CPMAC' refers to undefined symbol 'FIXED_MII_100_FDX'
>> Signed-off-by: Anton Vorontsov <avorontsov@...mvista.com>
>
> ACK

Is this going through netdev or do you want me to pick it via the  
powerpc route?

- k

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html