lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 30 Jan 2008 13:51:45 -0800 From: "Kok, Auke" <auke-jan.h.kok@...el.com> To: Adrian Bunk <bunk@...nel.org> CC: Joe Perches <joe@...ches.com>, Jeff Garzik <jeff@...zik.org>, jesse.brandeburg@...el.com, jeffrey.t.kirsher@...el.com, john.ronciak@...el.com, e1000-devel@...ts.sourceforge.net, netdev@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [2.6 patch] e1000e/ethtool.c: make a function static Adrian Bunk wrote: > This patch makes the needlessly global reg_pattern_test_array() static. > > Signed-off-by: Adrian Bunk <bunk@...nel.org> stephen hemminger already pointed this out to me... I'll certainly push this upstream, thanks Adrian! Auke > > --- > ed72e457f06311390d9a9e51a00c904939466aff > diff --git a/drivers/net/e1000e/ethtool.c b/drivers/net/e1000e/ethtool.c > index 6d9c27f..a2034cf 100644 > --- a/drivers/net/e1000e/ethtool.c > +++ b/drivers/net/e1000e/ethtool.c > @@ -690,8 +690,8 @@ err_setup: > return err; > } > > -bool reg_pattern_test_array(struct e1000_adapter *adapter, u64 *data, > - int reg, int offset, u32 mask, u32 write) > +static bool reg_pattern_test_array(struct e1000_adapter *adapter, u64 *data, > + int reg, int offset, u32 mask, u32 write) > { > int i; > u32 read; > -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists