netdev - Re: [PATCH 1/1 resend][arm/at91_ether.c] logical/bitand typo in function reset_phy() (inactive), drivers/net/arm/at91

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <47A037A7.4050102@pobox.com>
Date:	Wed, 30 Jan 2008 03:39:03 -0500
From:	Jeff Garzik <jgarzik@...ox.com>
To:	Roel Kluin <12o3l@...cali.nl>
CC:	andrew@...people.com, netdev@...r.kernel.org,
	linux-arm-kernel@...ts.arm.linux.org.uk
Subject: Re: [PATCH 1/1 resend][arm/at91_ether.c]  logical/bitand typo in
 function reset_phy() (inactive), drivers/net/arm/at91_ether.c

Roel Kluin wrote:
> include/linux/mii.h:48:#define BMCR_RESET 0x8000
> 
> The function reset_phy() is in "#if 0" inactivated code
> --
> Replace logical "&&" by bit "&" before BMCR_RESET
> 
> Signed-off-by: Roel Kluin <12o3l@...cali.nl>
> ---
> diff --git a/drivers/net/arm/at91_ether.c b/drivers/net/arm/at91_ether.c
> index 25b114a..0ae0d83 100644
> --- a/drivers/net/arm/at91_ether.c
> +++ b/drivers/net/arm/at91_ether.c
> @@ -384,7 +384,7 @@ static void reset_phy(struct net_device *dev)
>  	/* Wait until PHY reset is complete */
>  	do {
>  		read_phy(lp->phy_address, MII_BMCR, &bmcr);
> -	} while (!(bmcr && BMCR_RESET));
> +	} while (!(bmcr & BMCR_RESET));
>  
>  	disable_mdi();
>  	spin_unlock_irq(&lp->lock);

applied


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html