| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20080131092327.75b9c369@extreme> Date: Thu, 31 Jan 2008 09:23:27 -0800 From: Stephen Hemminger <shemminger@...ux-foundation.org> To: Andi Kleen <andi@...stfloor.org> Cc: netdev@...r.kernel.org Subject: Re: [PATCH] Disable TSO for non standard qdiscs On Thu, 31 Jan 2008 13:46:32 +0100 Andi Kleen <andi@...stfloor.org> wrote: > > TSO interacts badly with many queueing disciplines because they rely on > reordering packets from different streams and the large TSO packets can > make this difficult. This patch disables TSO for sockets that send over > devices with non standard queueing disciplines. That's anything but noop > or pfifo_fast and pfifo right now. > > Longer term other queueing disciplines could be checked if they > are also ok with TSO. If yes they can set the TCQ_F_GSO_OK flag too. > > It is still enabled for the standard pfifo_fast because that will never > reorder packets with the same type-of-service. This means 99+% of all users > will still be able to use TSO just fine. > > The status is only set up at socket creation so a shifted route > will not reenable TSO on a existing socket. I don't think that's a > problem though. > > Signed-off-by: Andi Kleen <ak@...e.de> > Fix the broken qdisc instead. -- Stephen Hemminger <stephen.hemminger@...tta.com> -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists