| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <47A20F3B.1060109@trash.net> Date: Thu, 31 Jan 2008 19:11:07 +0100 From: Patrick McHardy <kaber@...sh.net> To: Stephen Hemminger <shemminger@...ux-foundation.org> CC: Andi Kleen <andi@...stfloor.org>, netdev@...r.kernel.org Subject: Re: [PATCH] Disable TSO for non standard qdiscs Stephen Hemminger wrote: > On Thu, 31 Jan 2008 19:37:35 +0100 > Andi Kleen <andi@...stfloor.org> wrote: > >> On Thu, Jan 31, 2008 at 07:01:00PM +0100, Patrick McHardy wrote: >>> Andi Kleen wrote: >>>>> Fix the broken qdisc instead. >>>> What do you mean? I don't think the qdiscs are broken. >>>> I cannot think of any way how e.g. TBF can do anything useful >>>> with large TSO packets. >>> >>> Someone posted a patch some time ago to calculate the amount >>> of tokens needed in max_size portions and use that, but IMO >>> people should just configure TBF with the proper MTU for TSO. >> TBF with 64k atomic units will always be chunky and uneven. I don't >> think that's a useful goal. >> >> -Andi > > Then change TBF to use skb_gso_segment? Be careful, the fact that > one skb ends up queueing multiple skb's would cause issues to parent > qdisc (ie work generating qdisc). How about keeping the TSO-capable flag on qdiscs, propagating the non-capability up the tree and perform segmentation before queueing to the root? -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists