netdev - Re: rtl8150: use default MTU of 1500

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.1.00.0801311741400.4476@bender.nucleusys.com>
Date:	Thu, 31 Jan 2008 17:42:34 +0200 (EET)
From:	Petko Manolov <petkan@...leusys.com>
To:	Lennert Buytenhek <buytenh@...tstofly.org>
cc:	netdev@...r.kernel.org, jgarzik@...ox.com
Subject: Re: rtl8150: use default MTU of 1500

On Wed, 30 Jan 2008, Lennert Buytenhek wrote:

> The RTL8150 driver uses an MTU of 1540 by default, which causes a
> bunch of problems -- it prevents booting from NFS root, for one.

Agreed, although it is a bit strange how this particular bug has sneaked 
up for so long...


cheers,
Petko



> Signed-off-by: Lennert Buytenhek <buytenh@...tstofly.org>
> Cc: Petko Manolov <petkan@...leusys.com>
>
> --- linux-2.6.24-git7.orig/drivers/net/usb/rtl8150.c	2008-01-24 23:58:37.000000000 +0100
> +++ linux-2.6.24-git7/drivers/net/usb/rtl8150.c	2008-01-30 20:29:00.000000000 +0100
> @@ -925,9 +925,8 @@
> 	netdev->hard_start_xmit = rtl8150_start_xmit;
> 	netdev->set_multicast_list = rtl8150_set_multicast;
> 	netdev->set_mac_address = rtl8150_set_mac_address;
> 	netdev->get_stats = rtl8150_netdev_stats;
> -	netdev->mtu = RTL8150_MTU;
> 	SET_ETHTOOL_OPS(netdev, &ops);
> 	dev->intr_interval = 100;	/* 100ms */
>
> 	if (!alloc_all_urbs(dev)) {
>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html