[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <47A367A2.10706@pobox.com>
Date:	Fri, 01 Feb 2008 13:40:34 -0500
From:	Jeff Garzik <jgarzik@...ox.com>
To:	Anton Vorontsov <avorontsov@...mvista.com>
CC:	Li Yang <leoli@...escale.com>, netdev@...r.kernel.org,
	linuxppc-dev@...abs.org
Subject: Re: [PATCH for 2.6.25 1/2] [NET] ucc_geth: fix module removal
Anton Vorontsov wrote:
> - uccf should be set to NULL to not double-free memory on
>   subsequent calls;
> - ind_hash_q and group_hash_q lists should be initialized in the
>   probe() function, instead of struct_init() (called by open()),
>   otherwise there will be an oops if ucc_geth_driver removed
>   prior 'ifconfig ethX up';
> - add unregister_netdev();
> - reorder geth_remove() steps.
> 
> Signed-off-by: Anton Vorontsov <avorontsov@...mvista.com>
> ---
> 
> Hi Li,
> 
> You kinda promised that these two patches would hit 2.6.25... ;-)
> 
> I've rebased the patches so they apply cleanly on the current tree.
> 
> Thanks,
> 
>  drivers/net/ucc_geth.c |   17 ++++++++++-------
>  1 files changed, 10 insertions(+), 7 deletions(-)
applied 1-2
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists