[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <47A367B7.1030305@garzik.org>
Date: Fri, 01 Feb 2008 13:40:55 -0500
From: Jeff Garzik <jeff@...zik.org>
To: Haavard Skinnemoen <hskinnemoen@...el.com>
CC: netdev@...r.kernel.org, David Brownell <david-b@...bell.net>
Subject: Re: [PATCH] macb: Fix section mismatch and shrink runtime footprint
Haavard Skinnemoen wrote:
> macb devices are only found integrated on SoCs, so they can't be
> hotplugged. Thus, the probe() and exit() functions can be __init and
> __exit, respectively. By using platform_driver_probe() instead of
> platform_driver_register(), there won't be any references to the
> discarded probe() function after the driver has loaded.
>
> This also fixes a section mismatch due to macb_probe(), defined as
> __devinit, calling macb_get_hwaddr, defined as __init.
>
> Signed-off-by: Haavard Skinnemoen <hskinnemoen@...el.com>
> ---
> drivers/net/macb.c | 9 ++++-----
> 1 files changed, 4 insertions(+), 5 deletions(-)
applied
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists