netdev - RE: [PATCH] Disable TSO for non standard qdiscs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <D5C1322C3E673F459512FB59E0DDC32904737D65@orsmsx414.amr.corp.intel.com>
Date:	Fri, 1 Feb 2008 11:02:23 -0800
From:	"Waskiewicz Jr, Peter P" <peter.p.waskiewicz.jr@...el.com>
To:	<hadi@...erus.ca>, "Patrick McHardy" <kaber@...sh.net>
Cc:	"Andi Kleen" <andi@...stfloor.org>, "Glen Turner" <gdt@....id.au>,
	"Stephen Hemminger" <shemminger@...ux-foundation.org>,
	<netdev@...r.kernel.org>
Subject: RE: [PATCH] Disable TSO for non standard qdiscs

> Right - Essentially it is a usability issue:
> People who know how to use TSO (Peter for example) will be 
> clueful enough to turn it on. Which means the default should 
> be to protect the clueless and turn it off.
> On Andis approach:
> Turning TSO off at netdev registration time with a warning 
> will be a cleaner IMO. Or alternatively introducing a 
> kernel-config "I know what TSO is" option which is then used 
> at netdev registration. From a usability perspective it would 
> make more sense to just keep ethtool as the only way to 
> configure TSO. 

To me this sounds like the most reasonable approach.  I've put out my
concerns, so I'll get out of the way now so we can move forward in some
direction.  :-)

Cheers,

-PJ Waskiewicz
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html