netdev - Re: [PATCH] ipv6: update MSS even if MTU is unchanged

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20080131.163736.46142971.davem@davemloft.net>
Date:	Thu, 31 Jan 2008 16:37:36 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	jim@...n.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH] ipv6: update MSS even if MTU is unchanged

From: Jim Paris <jim@...n.com>
Date: Mon, 21 Jan 2008 17:02:48 -0500

> This is needed because in ndisc.c, we have:
> 
>   static void ndisc_router_discovery(struct sk_buff *skb)
>   {
>   // ...
>   	if (ndopts.nd_opts_mtu) {
>   // ...
>   			if (rt)
>   				rt->u.dst.metrics[RTAX_MTU-1] = mtu;
> 
>   			rt6_mtu_change(skb->dev, mtu);
>   // ...
>   }
> 
> Since the mtu is set directly here, rt6_mtu_change_route thinks that
> it is unchanged, and so it fails to update the MSS accordingly.  This
> patch lets rt6_mtu_change_route still update MSS if old_mtu == new_mtu.
> 
> Signed-off-by: Jim Paris <jim@...n.com>

This seems ok, patch applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html