netdev - Re: [PATCH] [POWERPC][NET][SERIAL] UCCs: replace device-id with cell-index

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <47A35C66.80008@pobox.com>
Date:	Fri, 01 Feb 2008 12:52:38 -0500
From:	Jeff Garzik <jgarzik@...ox.com>
To:	avorontsov@...mvista.com
CC:	Kumar Gala <galak@...nel.crashing.org>,
	Timur Tabi <timur@...escale.com>,
	Grant Likely <grant.likely@...retlab.ca>,
	Li Yang <leoli@...escale.com>, linuxppc-dev@...abs.org,
	linux-serial@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: [PATCH] [POWERPC][NET][SERIAL] UCCs: replace device-id with cell-index

Anton Vorontsov wrote:
> On Fri, Feb 01, 2008 at 09:32:38AM -0600, Kumar Gala wrote:
>> On Feb 1, 2008, at 9:01 AM, Anton Vorontsov wrote:
>>
>>> It isn't used anywhere, so remove it. If we'll ever need something
>>> like this, we'll use compatible property instead.
>>>
>>> Signed-off-by: Anton Vorontsov <avorontsov@...mvista.com>
>>> ---
>>>
>>> Rebased on top of recent tree.
>>>
>>> Documentation/powerpc/booting-without-of.txt |    1 -
>>> arch/powerpc/boot/dts/mpc832x_mds.dts        |    3 ---
>>> arch/powerpc/boot/dts/mpc832x_rdb.dts        |    2 --
>>> arch/powerpc/boot/dts/mpc836x_mds.dts        |    2 --
>>> arch/powerpc/boot/dts/mpc8568mds.dts         |    2 --
>>> 5 files changed, 0 insertions(+), 10 deletions(-)
>>>
>>> diff --git a/Documentation/powerpc/booting-without-of.txt b/ 
>>> Documentation/powerpc/booting-without-of.txt
>>> index 410c847..dcf9758 100644
>>> --- a/Documentation/powerpc/booting-without-of.txt
>>> +++ b/Documentation/powerpc/booting-without-of.txt
>>> @@ -1675,7 +1675,6 @@ platforms are moved over to use the flattened- 
>>> device-tree model.
>>> 	ucc@...0 {
>>> 		device_type = "network";
>>> 		compatible = "ucc_geth";
>>> -		model = "UCC";
>>> 		device-id = <1>;
>> can we change device-id to cell-index?
> 
> Sure. But let's do this in the separate patch? Because this change
> actually touches the code in the two subsystems: net and serial.
> 
> I hope everybody will agree to pass it through powerpc tree..?
> 
> - - - -
> From: Anton Vorontsov <avorontsov@...mvista.com>
> Subject: [POWERPC][NET][SERIAL] UCCs: replace device-id with cell-index
> 
> device-id is worse than cell-index. Probably cell-index isn't
> good either, but device-id is worse anyway.
> 
> Drivers are modified for backward compatibility's sake.
> 
> Signed-off-by: Anton Vorontsov <avorontsov@...mvista.com>
> ---
>  Documentation/powerpc/booting-without-of.txt |    4 ++--
>  arch/powerpc/boot/dts/mpc832x_mds.dts        |    4 +---
>  arch/powerpc/boot/dts/mpc832x_rdb.dts        |    2 --
>  arch/powerpc/boot/dts/mpc836x_mds.dts        |    2 --
>  arch/powerpc/boot/dts/mpc836x_rdk.dts        |   12 ++++++------
>  arch/powerpc/boot/dts/mpc8568mds.dts         |    2 --
>  drivers/net/ucc_geth.c                       |    8 +++++++-
>  drivers/net/ucc_geth_mii.c                   |   11 ++++++++---
>  drivers/serial/ucc_uart.c                    |   16 ++++++++++++----
>  9 files changed, 36 insertions(+), 25 deletions(-)

ACK drivers/net


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html