[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Sat, 2 Feb 2008 22:08:34 +0100
From: Ondrej Zary <linux@...nbow-software.org>
To: Jeff Garzik <jeff@...zik.org>
Cc: netdev@...r.kernel.org,
Linux Kernel <linux-kernel@...r.kernel.org>,
Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH] [RFC] 3c509: convert to isa_driver and pnp_driver v2
On Saturday 02 February 2008 21:50:25 Jeff Garzik wrote:
> Ondrej Zary wrote:
> > Hello,
> > this is second version of the patch. Autoloading using udev works fine
> > with PnP card. Hibernation now works both in PnP and ISA modes. The I/O
> > address used for non-pnp ISA card detection is now not released as it's
> > needed to wake up the card.
> >
> > Manual irq and transceiver settings aren't implemented yet. Operation
> > with multiple cards is not tested - I'll try 3 cards in both PnP and ISA
> > modes. There is some code that is the same in each of the 4 probe
> > functions (isa, pnp, eisa and mca), which should be probably separated
> > into a function.
> >
> > I have no EISA or MCA machine so I hope that I didn't break them.
>
> Looks pretty good at first glance...
>
> I'll throw it in my queue. Want to add a signed-off-by: ?
>
> Jeff
I think that the ISA resume will not work with more than 1 card. I'll fix that
first and test with 3 cards. So the next version can include signed-off-by.
I also wonder about the old el3_cleanup_module() function - it called
el3_common_remove for all cards. With isa_driver and pnp_driver, it oopsed -
I think that's because the remove() functions were called by driver core on
isa_unregister_driver (and pnp_unregister_driver) - but what about MCA and
EISA?
--
Ondrej Zary
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists