netdev - Re: linux-2.6.24 compile error in drivers/net/b44.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <47A51F77.60509@cn.fujitsu.com>
Date:	Sun, 03 Feb 2008 09:57:11 +0800
From:	Li Zefan <lizf@...fujitsu.com>
To:	Miguel Botón <mboton@...il.com>
CC:	LKML <linux-kernel@...r.kernel.org>, netdev@...r.kernel.org,
	David Miller <davem@...emloft.net>, zambrano@...adcom.com,
	linville@...driver.com
Subject: Re: linux-2.6.24 compile error in drivers/net/b44.c

Li Zefan wrote:
> Miguel Botón 写道:
>> Li Zefan wrote:
>>> Add CCs:
>>>
>>> CC: mboton@...il.com
>>> CC: zambrano@...adcom.com
>>> CC: linville@...driver.com
>>>
>>> Li Zefan wrote:
>>>> drivers/net/b44.c: In function 'b44_remove_one':
>>>> drivers/net/b44.c:2231: error: implicit declaration of function 'ssb_pcihost_set_power_state'
>>>> make[2]: *** [drivers/net/b44.o] Error 1
>>>> make[1]: *** [drivers/net] Error 2
>>>>
>>>> I think it is caused by:
>>>>
>>>> CONFIG_SSB_PCIHOST=n
>>>> CONFIG_B44=y
>>>>
>> This patch should fix b44 errors when 'SSB_PCIHOST' is not enabled.
>>
> 
> I tried the patch, but it does't work, same compile error. :(
> 
> If .config is needed, tell me and I will attach it.
> 

Sorry, I just made a mistake, actually the patch works.

Thanks!

>> Signed-off-by: Miguel Botón <mboton@...il.com>
>>
>> diff --git a/drivers/net/b44.c b/drivers/net/b44.c
>> index ea2a2b5..d081234 100644
>> --- a/drivers/net/b44.c
>> +++ b/drivers/net/b44.c
>> @@ -2228,7 +2228,9 @@ static void __devexit b44_remove_one(struct ssb_device *sdev)
>>  	unregister_netdev(dev);
>>  	ssb_bus_may_powerdown(sdev->bus);
>>  	free_netdev(dev);
>> +#ifdef B44_PCI
>>  	ssb_pcihost_set_power_state(sdev, PCI_D3hot);
>> +#endif
>>  	ssb_set_drvdata(sdev, NULL);
>>  }
>>  
>> @@ -2257,7 +2259,9 @@ static int b44_suspend(struct ssb_device *sdev, pm_message_t state)
>>  		b44_setup_wol(bp);
>>  	}
>>  
>> +#ifdef B44_PCI
>>  	ssb_pcihost_set_power_state(sdev, PCI_D3hot);
>> +#endif
>>  	return 0;
>>  }
>>  
>> --
>> 	Miguel Botón
>>
>>
> 
> 
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html