netdev - Re: [PATCH 07/24 for-2.6.25] DM9000: Add initial ethtool support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080205225045.GA12258@electric-eye.fr.zoreil.com>
Date:	Tue, 5 Feb 2008 23:50:45 +0100
From:	Francois Romieu <romieu@...zoreil.com>
To:	Ben Dooks <ben-linux@...ff.org>
Cc:	netdev@...r.kernel.org, jeff@...zik.org, akpm@...ux-foundation.org,
	daniel@...aq.de, laurentp@...-semaphore.com
Subject: Re: [PATCH 07/24 for-2.6.25] DM9000: Add initial ethtool support

Ben Dooks <ben-linux@...ff.org> :
> Add support for ethtool operations for the DM9000.
> 
> Signed-off-by: Ben Dooks <ben-linux@...ff.org>
> 
> Index: linux-2.6.24-quilt3/drivers/net/dm9000.c
> ===================================================================
> --- linux-2.6.24-quilt3.orig/drivers/net/dm9000.c
> +++ linux-2.6.24-quilt3/drivers/net/dm9000.c
[...]
> +static int dm9000_get_settings(struct net_device *dev, struct ethtool_cmd *cmd)
> +{
> +	board_info_t *dm = to_dm9000_board(dev);
> +	unsigned long flags;
> +
> +	spin_lock_irqsave(&dm->lock, flags);
> +	mii_ethtool_gset(&dm->mii, cmd);

drivers/net/mii.c::mii_ethtool_gset
[...]
        advert = mii->mdio_read(dev, mii->phy_id, MII_ADVERTISE);

drivers/net/dm9000.c::dm9000_probe
[...]
        db->mii.mdio_read    = dm9000_phy_read;

drivers/net/dm9000.c::dm9000_phy_read
[...]
        board_info_t *db = (board_info_t *) dev->priv;
        unsigned long flags;
        unsigned int reg_save;
        int ret;

        spin_lock_irqsave(&db->lock,flags);

-> deadlock

-- 
Ueimor
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html