netdev - Re: [PATCH 07/24 for-2.6.25] DM9000: Add initial ethtool support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080206220334.GE15407@fluff.org.uk>
Date:	Wed, 6 Feb 2008 22:03:34 +0000
From:	Ben Dooks <ben@...ff.org>
To:	Francois Romieu <romieu@...zoreil.com>
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH 07/24 for-2.6.25] DM9000: Add initial ethtool support

On Tue, Feb 05, 2008 at 11:50:45PM +0100, Francois Romieu wrote:
> Ben Dooks <ben-linux@...ff.org> :
> > Add support for ethtool operations for the DM9000.
> > 
> > Signed-off-by: Ben Dooks <ben-linux@...ff.org>
> > 
> > Index: linux-2.6.24-quilt3/drivers/net/dm9000.c
> > ===================================================================
> > --- linux-2.6.24-quilt3.orig/drivers/net/dm9000.c
> > +++ linux-2.6.24-quilt3/drivers/net/dm9000.c
> [...]
> > +static int dm9000_get_settings(struct net_device *dev, struct ethtool_cmd *cmd)
> > +{
> > +	board_info_t *dm = to_dm9000_board(dev);
> > +	unsigned long flags;
> > +
> > +	spin_lock_irqsave(&dm->lock, flags);
> > +	mii_ethtool_gset(&dm->mii, cmd);
> 
> drivers/net/mii.c::mii_ethtool_gset
> [...]
>         advert = mii->mdio_read(dev, mii->phy_id, MII_ADVERTISE);
> 
> drivers/net/dm9000.c::dm9000_probe
> [...]
>         db->mii.mdio_read    = dm9000_phy_read;
> 
> drivers/net/dm9000.c::dm9000_phy_read
> [...]
>         board_info_t *db = (board_info_t *) dev->priv;
>         unsigned long flags;
>         unsigned int reg_save;
>         int ret;
> 
>         spin_lock_irqsave(&db->lock,flags);
> 
> -> deadlock

The next patch in the series changes the locking.

-- 
Ben (ben@...ff.org, http://www.fluff.org/)

  'a smiley only costs 4 bytes'
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html