netdev - Re: [patch 1/4] ctc / netiucv: consolidate fsm_action

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080207062621.GA27498@infradead.org>
Date:	Thu, 7 Feb 2008 01:26:21 -0500
From:	Christoph Hellwig <hch@...radead.org>
To:	Ursula Braun <braunu@...ibm.com>
Cc:	jgarzik@...ox.com, netdev@...r.kernel.org,
	linux-s390@...r.kernel.org, Peter Tiedemann <ptiedem@...ibm.com>
Subject: Re: [patch 1/4] ctc / netiucv: consolidate fsm_action_nop

On Wed, Feb 06, 2008 at 07:27:24PM +0100, Ursula Braun wrote:
> +/**
> + * NOP action for statemachines
> + */
> +static inline void
> +fsm_action_nop(fsm_instance *fi, int event, void *arg)
> +{
> +}

This is put into a method table, which means taking the address of it.
So marking this inline doesn't make much sense, it should be out of
line somewhere in common code.

>  static struct device_driver netiucv_driver = {
> +	.owner = THIS_MODULE,
>  	.name = "netiucv",
>  	.bus  = &iucv_bus,


This is uncodumented in the changelog and completely unrelated
to the other change in here.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html