Subject: [RFC] remove skb->dev NULL assignation From: Daniel Lezcano I was trying to figure out why in the tcp_v4_rcv/tcp_v6_rcv function, the skb->dev field is set to NULL. There is certainly a good reason, but I was not able to find it. Is it possible to remove this ? Signed-off-by: Daniel Lezcano --- net/ipv4/tcp_ipv4.c | 2 -- net/ipv6/tcp_ipv6.c | 2 -- 2 files changed, 4 deletions(-) Index: net-2.6/net/ipv4/tcp_ipv4.c =================================================================== --- net-2.6.orig/net/ipv4/tcp_ipv4.c +++ net-2.6/net/ipv4/tcp_ipv4.c @@ -1661,8 +1661,6 @@ process: if (sk_filter(sk, skb)) goto discard_and_relse; - skb->dev = NULL; - bh_lock_sock_nested(sk); ret = 0; if (!sock_owned_by_user(sk)) { Index: net-2.6/net/ipv6/tcp_ipv6.c =================================================================== --- net-2.6.orig/net/ipv6/tcp_ipv6.c +++ net-2.6/net/ipv6/tcp_ipv6.c @@ -1722,8 +1722,6 @@ process: if (sk_filter(sk, skb)) goto discard_and_relse; - skb->dev = NULL; - bh_lock_sock_nested(sk); ret = 0; if (!sock_owned_by_user(sk)) {