netdev - Re: [RFC] [IPV4][IPV6][TCP] remove skb->dev NULL assignation in tcp_v[4|6]

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20080207.034525.74982838.davem@davemloft.net>
Date:	Thu, 07 Feb 2008 03:45:25 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	dlezcano@...ibm.com
Cc:	netdev@...r.kernel.org
Subject: Re: [RFC] [IPV4][IPV6][TCP] remove skb->dev NULL assignation in
 tcp_v[4|6]_rcv functions

From: Daniel Lezcano <dlezcano@...ibm.com>
Date: Thu, 07 Feb 2008 12:17:27 +0100

> Subject: [RFC] remove skb->dev NULL assignation
> 
> I was trying to figure out why in the tcp_v4_rcv/tcp_v6_rcv function,
> the skb->dev field is set to NULL. There is certainly a good reason,
> but I was not able to find it.
> 
> Is it possible to remove this ?
> 
> Signed-off-by: Daniel Lezcano <dlezcano@...ibm.com>

It is illegal to reference a device outside of the netif_receive_skb()
code path without taking a reference to it.

Since we are queueing it to a socket, we have to NULL out the skb->dev
since thee packets lifetime is being expanded outside of that allowed
window.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html