netdev - Re: [patch 3/4] ctcm: infrastructure for replaced ctc driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.58.0802070648020.547@force5.casita.net>
Date:	Thu, 7 Feb 2008 06:52:06 -0500 (EST)
From:	Rick Troth <rmt@...ita.net>
To:	Christoph Hellwig <hch@...radead.org>
Cc:	Ursula Braun <braunu@...ibm.com>, jgarzik@...ox.com,
	netdev@...r.kernel.org, linux-s390@...r.kernel.org,
	Peter Tiedemann <ptiedem@...ibm.com>
Subject: Re: [patch 3/4] ctcm: infrastructure for replaced ctc driver

On Thu, 7 Feb 2008, Christoph Hellwig wrote:
 ...
> > +/*
> > + *	drivers/s390/net/ctcm_dbug.c
> > + *
> > + *	Copyright IBM Corp. 2001, 2007
> > + *	Authors:	Peter Tiedemann (ptiedem@...ibm.com)
> > + *
> > + */
>
> Please don't mention filenames in the top of file comments.
> On the other hand a little description of what this file
> does would be quite useful.  (This comment applies to all
> files in this patch)

Better descriptions, yes.  Of course.
But are you saying to NOT name the file in its comments?
I am surprised.  If I am reading correctly, then I disagree.

Is the exclusion of the name of the source file from its comments
a stylistic decision the other kernel developers have agreed to?
Or is it tied to automation?  Or have I (hopefully) misunderstood?

-- R;   <><

()  ascii ribbon campaign - against html e-mail
/\  www.asciiribbon.org   - against proprietary attachments



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html