netdev - Re: [PATCH 1/2][SCTP]: Use snmp_fold_field instead of a homebrew analogue.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <47AC6E6A.4000101@hp.com>
Date:	Fri, 08 Feb 2008 09:59:54 -0500
From:	Vlad Yasevich <vladislav.yasevich@...com>
To:	Pavel Emelyanov <xemul@...nvz.org>
Cc:	David Miller <davem@...emloft.net>,
	lksctp-developers@...ts.sourceforge.net,
	Linux Netdev List <netdev@...r.kernel.org>
Subject: Re: [PATCH 1/2][SCTP]: Use snmp_fold_field instead of a homebrew
 analogue.

Pavel Emelyanov wrote:
> SCPT already depends in INET, so this doesn't create additional
> dependencies.
> 
> Signed-off-by: Pavel Emelyanov <xemul@...nvz.org>

Acked-by: Vlad Yasevich <vladislav.yasevich@...com>

> 
> ---
>  net/sctp/proc.c |   23 ++---------------------
>  1 files changed, 2 insertions(+), 21 deletions(-)
> 
> diff --git a/net/sctp/proc.c b/net/sctp/proc.c
> index 2499732..974350b 100644
> --- a/net/sctp/proc.c
> +++ b/net/sctp/proc.c
> @@ -38,6 +38,7 @@
>  #include <linux/seq_file.h>
>  #include <linux/init.h>
>  #include <net/sctp/sctp.h>
> +#include <net/ip.h> /* for snmp_fold_field */
>  
>  static struct snmp_mib sctp_snmp_list[] = {
>  	SNMP_MIB_ITEM("SctpCurrEstab", SCTP_MIB_CURRESTAB),
> @@ -75,26 +76,6 @@ static struct snmp_mib sctp_snmp_list[] = {
>  	SNMP_MIB_SENTINEL
>  };
>  
> -/* Return the current value of a particular entry in the mib by adding its
> - * per cpu counters.
> - */
> -static unsigned long
> -fold_field(void *mib[], int nr)
> -{
> -	unsigned long res = 0;
> -	int i;
> -
> -	for_each_possible_cpu(i) {
> -		res +=
> -		    *((unsigned long *) (((void *) per_cpu_ptr(mib[0], i)) +
> -					 sizeof (unsigned long) * nr));
> -		res +=
> -		    *((unsigned long *) (((void *) per_cpu_ptr(mib[1], i)) +
> -					 sizeof (unsigned long) * nr));
> -	}
> -	return res;
> -}
> -
>  /* Display sctp snmp mib statistics(/proc/net/sctp/snmp). */
>  static int sctp_snmp_seq_show(struct seq_file *seq, void *v)
>  {
> @@ -102,7 +83,7 @@ static int sctp_snmp_seq_show(struct seq_file *seq, void *v)
>  
>  	for (i = 0; sctp_snmp_list[i].name != NULL; i++)
>  		seq_printf(seq, "%-32s\t%ld\n", sctp_snmp_list[i].name,
> -			   fold_field((void **)sctp_statistics,
> +			   snmp_fold_field((void **)sctp_statistics,
>  				      sctp_snmp_list[i].entry));
>  
>  	return 0;

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html