lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 8 Feb 2008 09:52:33 -0800 From: Andrew Morton <akpm@...ux-foundation.org> To: David Dillow <dave@...dillows.org> Cc: davem@...emloft.net, jeff@...zik.org, netdev@...r.kernel.org, sam@...nborg.org Subject: Re: [patch 1/7] typhoon section fix On Fri, 08 Feb 2008 08:59:10 -0500 David Dillow <dave@...dillows.org> wrote: > > On Fri, 2008-02-08 at 03:11 -0800, akpm@...ux-foundation.org wrote: > > From: Andrew Morton <akpm@...ux-foundation.org> > > > > gcc-3.4.4 on powerpc: > > > > drivers/net/typhoon.c:137: error: version causes a section type conflict > > > > Cc: Jeff Garzik <jeff@...zik.org> > > Cc: Sam Ravnborg <sam@...nborg.org> > > Signed-off-by: Andrew Morton <akpm@...ux-foundation.org> > > > -static const char version[] __devinitdata = > > +static char version[] __devinitdata = > > "typhoon.c: version " DRV_MODULE_VERSION " (" DRV_MODULE_RELDATE ")\n"; > > Wouldn't going to __devinitconst be better? I'll try to whip up a patch > and test-compile it. Sam told me that doesn't work right, that this approach is the one to use and, iirc, that __devinitcont and friends will be removed. I'm not sure why, actually. I think I missed that dicussion. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists