netdev - Re: [PATCH] libertas: Don't mark exported symbols as static

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 09 Feb 2008 08:52:35 -0500
From:	Dan Williams <dcbw@...hat.com>
To:	Christoph Hellwig <hch@...radead.org>
Cc:	Roland Dreier <rdreier@...co.com>,
	Stephen Hemminger <shemminger@...ux-foundation.org>,
	netdev@...r.kernel.org
Subject: Re: [PATCH] libertas: Don't mark exported symbols as static

On Fri, 2008-02-08 at 23:48 -0500, Christoph Hellwig wrote:
> On Fri, Feb 08, 2008 at 06:01:02PM -0800, Roland Dreier wrote:
> >  > Why not pull the exports? they aren't used anywhere in the existing kernel.
> > 
> > I'm guessing there's some not-(yet-)merged mesh networking stuff that
> > uses the symbols, but it doesn't matter much to me...
> 
> The general rule is to not keep symbols for out of tree stuff, so
> removing the exports makes more sense.

If they aren't used in the in-kernel driver, just kill the export
statements.

Dan

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html