netdev - Re: [PATCH 1/2] fib_trie: handle empty tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <20080211.211407.08993863.davem@davemloft.net>
Date:	Mon, 11 Feb 2008 21:14:07 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	shemminger@...tta.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH 1/2] fib_trie: handle empty tree

From: Stephen Hemminger <shemminger@...tta.com>
Date: Mon, 11 Feb 2008 17:12:50 -0800

> To: David S. Miller <davem@...emloft.net>

When a user's name has "special" characters such as a "."  as mine
does, it must be surrounded by double-quotes or else it is a syntax
error by SMTP rules.  For this reason your patch postings were
rejected by vger.kernel.org

> This fixes possible problems when trie_firstleaf() returns NULL
> to trie_leafindex().
> 
> Signed-off-by: Stephen Hemminger <shemminger@...tta.com>

Applied, thanks Stephen.

> diff --git a/net/ipv4/fib_trie.c b/net/ipv4/fib_trie.c
> index f5fba3f..2d89527 100644
> --- a/net/ipv4/fib_trie.c
> +++ b/net/ipv4/fib_trie.c
> @@ -1762,11 +1762,9 @@ static struct leaf *trie_leafindex(struct trie *t, int index)
>  {
>  	struct leaf *l = trie_firstleaf(t);
>  
> -	while (index-- > 0) {
> +	while (l && index-- > 0)
>  		l = trie_nextleaf(l);
> -		if (!l)
> -			break;
> -	}
> +
>  	return l;
>  }
>  
> -- 
> 1.5.3.8
> 
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html