netdev - Re: [PATCH] [TC U32] Fix input parsing to support more than 9 flow id'scorrectly

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 12 Feb 2008 19:26:52 -0800
From:	Stephen Hemminger <stephen.hemminger@...tta.com>
To:	"Waskiewicz Jr, Peter P" <peter.p.waskiewicz.jr@...el.com>
CC:	netdev@...r.kernel.org
Subject: Re: [PATCH] [TC U32] Fix input parsing to support more than 9 flow
 id'scorrectly

Waskiewicz Jr, Peter P wrote:
>> From: PJ Waskiewicz <peter.p.waskiewicz.jr@...el.com>
>>
>> Using strtoul with a base of 16 converts flowid 10 into 0x10, 
>> which makes it flowid 16.  This is interpreted by the kernel 
>> incorrectly, and causes traffic flows above 9 to be 
>> classified into band 0 on multiband qdiscs.
>> This changes the base to 10, which will correctly parse input 
>> into the proper hexidecimal value.
>>     
>
> Stephen,
> 	We can go one of two ways I suppose.  Once is this way, since
> most user input for CLASSID is base 10, or we can update documentation
> to say that CLASSID input is expected to be base 16.  What do you think?
>
> Thanks,
> -PJ Waskiewicz
> peter.p.waskiewicz.jr@...el.com
>
>   
Sorry, can't change the api, update the documentation instead.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html