netdev - Re: [PATCH 2/3][NETLABEL]: Don't produce unused variables when IPv6 is off.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20080212.223733.253093661.davem@davemloft.net>
Date:	Tue, 12 Feb 2008 22:37:33 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	xemul@...nvz.org
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH 2/3][NETLABEL]: Don't produce unused variables when
 IPv6 is off.

From: Pavel Emelyanov <xemul@...nvz.org>
Date: Thu, 07 Feb 2008 20:24:15 +0300

> Some code declares variables on the stack, but uses them
> under #ifdef CONFIG_IPV6, so thay become unused when ipv6
> is off. Fortunately, they are used in a switch's case
> branches, so the fix is rather simple.
> 
> Is it OK from coding style POV to add braces inside "cases",
> or should I better avoid such style and rework the patch?
> 
> Signed-off-by: Pavel Emelyanov <xemul@...nvz.org>

Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html