netdev - Re: [PATCH] rtnetlink.c: send a single notification on device state changes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20080212.224252.03600088.davem@davemloft.net>
Date:	Tue, 12 Feb 2008 22:42:52 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	panther@...abit.hu
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH] rtnetlink.c: send a single notification on device
 state changes

From: Laszlo Attila Toth <panther@...abit.hu>
Date: Thu,  7 Feb 2008 12:57:50 +0100

> In do_setlink() a single notification is sent at the end of the function
> if any modification occured. If the address has been changed, another
> notification is sent.
> 
> Both of them is required because originally only the NETDEV_CHANGEADDR
> notification was sent and although device state change implies address
> change, some programs may expect the original notification. It remains
> for compatibity.
> 
> If set_operstate() is called from do_setlink(), it doesn't send
> a notification, only if it is called from rtnl_create_link() as earlier.
> 
> Signed-off-by: Laszlo Attila Toth <panther@...abit.hu>

Looks good, applied.

Let's hope this doesn't break some stupid application
unintentionally.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html