netdev - [Bug 9750] [patch 2.6.25 v2] dev: avoid a race that triggers assertion failure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <127401.85852.qm@web52006.mail.re2.yahoo.com>
Date:	Tue, 12 Feb 2008 23:06:41 -0800 (PST)
From:	Matti Linnanvuori <mattilinnanvuori@...oo.com>
To:	bugme-daemon@...zilla.kernel.org, davem@...emloft.net,
	netdev@...r.kernel.org
Subject: [Bug 9750] [patch 2.6.25 v2] dev: avoid a race that triggers assertion failure

From: Matti Linnanvuori <mattilinnanvuori@...oo.com>

There is a race in Linux kernel file net/core/dev.c, function dev_close.
The function calls function dev_deactivate, which calls function
dev_watchdog_down that deletes the watchdog timer. However, after that, a
driver can call netif_carrier_ok, which calls function
__netdev_watchdog_up that can add the watchdog timer again. Function
unregister_netdevice calls function dev_shutdown that traps the bug
!timer_pending(&dev->watchdog_timer). Moving dev_deactivate after
netif_running() has been cleared prevents function netif_carrier_on
from calling __netdev_watchdog_up and adding the watchdog timer again.

Signed-off-by: Matti Linnanvuori <mattilinnanvuori@...oo.com>

---

      ____________________________________________________________________________________
Never miss a thing.  Make Yahoo your home page. 
http://www.yahoo.com/r/hs
Download attachment "patch" of type "application/octet-stream" (1351 bytes)