netdev - Re: [PATCH] [IRDA] irda_init() nuke useless debug printk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20080213105158.GA15544@stro.at>
Date:	Wed, 13 Feb 2008 11:51:58 +0100
From:	maximilian attems <max@...o.at>
To:	David Miller <davem@...emloft.net>
Cc:	netdev@...r.kernel.org, Samuel Ortiz <samuel@...tiz.org>
Subject: Re: [PATCH] [IRDA] irda_init() nuke useless debug printk

On Tue, 12 Feb 2008, David Miller wrote:

> From: maximilian attems <max@...o.at>
> Date: Tue, 12 Feb 2008 11:30:47 +0100
> 
> > irda_init()
> > dmesg line is not really informative, thus remove it.
> > There are better ways to know that a module is loaded.
> > 
> > Seen on a debian config with IRDA_DEBUG enabled.
> > 
> > Signed-off-by: maximilian attems <max@...o.at>
> 
> Well if you look at how IRDA_DEBUG is predominantly used,
> it's a function tracer, and that's exactly how it's being
> used here.
> 
> Either we decide that this is OK and leave it there, or
> we start moving the whole IRDA tree over to not do this.
> Not something in between.

ack, happy with both.
i could also lower the visibility of that one.

it simply struck out on my sfuzz test runs, had this
dmesg line instead of usual stuff:
-- snipp
NET: Registered protocol family 9
X.25 for Linux Version 0.2
Bridge firewalling registered
PPP generic driver version 2.4.2
NET: Registered protocol family 24
Sangoma WANPIPE Router v1.1 (c) 1995-2000 Sangoma Technologies Inc.
NET: Registered protocol family 4
NET4: DECnet for Linux: V.2.5.68s (C) 1995-2003 Linux DECnet Project Team
DECnet: Routing cache hash table of 1024 buckets, 16Kbytes
NET: Registered protocol family 12
Bluetooth: Core ver 2.11
NET: Registered protocol family 31
Bluetooth: HCI device and connection manager initialized
Bluetooth: HCI socket layer initialized
NET: Registered protocol family 15
NET: Registered protocol family 5
irda_init()
NET: Registered protocol family 23
--
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html