netdev - Re: [PATCH 2.6.25] igb: fix legacy mode irq issue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <47B5B5BA.9020807@garzik.org>
Date:	Fri, 15 Feb 2008 10:54:34 -0500
From:	Jeff Garzik <jeff@...zik.org>
To:	Andy Gospodarek <andy@...yhouse.net>
CC:	netdev@...r.kernel.org, Auke Kok <auke-jan.h.kok@...el.com>,
	"David S. Miller" <davem@...emloft.net>
Subject: Re: [PATCH 2.6.25] igb: fix legacy mode irq issue

Andy Gospodarek wrote:
> I booted an igb kernel with the option pci=nomsi and instantly noticed
> that interrupts no longer worked on my igb device.  I took a look at the
> interrupt initialization and quickly discovered a comment stating:
> 
> "DO NOT USE EIAME or IAME in legacy mode"
> 
> It seemed a bit odd that bits to enable IAM were being set in legacy
> interrupt mode, so I dropped out the following parts and interrupts
> began working fine again.
> 
> Signed-off-by: Andy Gospodarek <andy@...yhouse.net>
> ---
> 
>  igb_main.c |    3 ---
>  1 files changed, 3 deletions(-)
> 
> diff --git a/drivers/net/igb/igb_main.c b/drivers/net/igb/igb_main.c
> index f3c144d..be5da09 100644
> --- a/drivers/net/igb/igb_main.c
> +++ b/drivers/net/igb/igb_main.c
> @@ -472,9 +471,6 @@ static int igb_request_irq(struct igb_adapter *adapter)
>  		goto request_done;
>  	}
>  
> -	/* enable IAM, auto-mask */
> -	wr32(E1000_IAM, IMS_ENABLE_MASK);
> -

ACK from Auke?  (apologies if I missed it...)


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html