netdev - Re: [NETFILTER]: Introduce nf_inet

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <1203428949.3223.25.camel@shinybook.infradead.org>
Date:	Tue, 19 Feb 2008 22:49:08 +0900
From:	David Woodhouse <dwmw2@...radead.org>
To:	netdev@...r.kernel.org
Cc:	Jan Engelhardt <jengelh@...putergmbh.de>,
	Patrick McHardy <kaber@...sh.net>,
	"David S. Miller" <davem@...emloft.net>, varevoka@...hat.com
Subject: Re: [NETFILTER]: Introduce nf_inet_address

On Tue, 2008-01-29 at 13:16 +0000, Linux Kernel Mailing List wrote:
> Commit:     643a2c15a407faf08101a20e1a3461160711899d
>
>     [NETFILTER]: Introduce nf_inet_address
>     
>     A few netfilter modules provide their own union of IPv4 and IPv6
>     address storage. Will unify that in this patch series.
>     
>     (1/4): Rename union nf_conntrack_address to union nf_inet_addr and
>     move it to x_tables.h.
>     
>     Signed-off-by: Jan Engelhardt <jengelh@...putergmbh.de>
>     Signed-off-by: Patrick McHardy <kaber@...sh.net>
>     Signed-off-by: David S. Miller <davem@...emloft.net>

 ...

> --- a/include/linux/netfilter.h
> +++ b/include/linux/netfilter.h
> @@ -48,6 +48,12 @@ enum nf_inet_hooks {
>  	NF_INET_NUMHOOKS
>  };
>  
> +union nf_inet_addr {
> +	u_int32_t	all[4];
> +	__be32		ip;
> +	__be32		ip6[4];
> +};
> +
>  #ifdef __KERNEL__
>  #ifdef CONFIG_NETFILTER

This breaks the busybox build:

CC      ipsvd/tcpudp.o
In file included from /usr/include/linux/netfilter_ipv4.h:8,
                 from ipsvd/tcpudp.c:33:
/usr/include/linux/netfilter.h:40: error: expected specifier-qualifier-list before 'u_int32_t'

What is this 'u_int32_t' nonsense anyway?

If a user-visible header is likely to be included by libc directly from
a 'standard' header, it may not require <stdint.h>. Therefore it should
use the system-specific types such as '__u32'.

If it isn't likely to be included by libc, which is the case for
netfilter, then it might as well just use the proper C types. Those who
are stuck on C89 or earlier might still prefer to use '__u32' even when
there's no need for it, but 'u_int32_t' is just silly. I suspect we
should eradicate it. I couldn't make busybox work with it --
__BIT_TYPES_DEFINED__ is defined in <sys/types.h> and prevents the
definitions of u_int32_t et al from appearing in <linux/types.h>. And if
I include <linux/types.h> first, other things break.

A later commit adds struct in_addr and struct in6_addr to this union
too, which breaks busybox even harder.

How is this supposed to be used in userspace? Or is it even supposed to
be exposed?

-- 
dwmw2

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html