netdev - Re: [PATCH] net/8021q/vlan_dev.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <47BA3131.3080907@snapgear.com>
Date:	Tue, 19 Feb 2008 11:30:25 +1000
From:	Philip Craig <philipc@...pgear.com>
To:	Joe Perches <joe@...ches.com>
CC:	David Miller <davem@...emloft.net>, kaber@...sh.net,
	bruno@...nktube.com, netdev@...r.kernel.org, jgarzik@...ox.com,
	linux-wireless@...r.kernel.org, linville@...driver.com
Subject: Re: [PATCH] net/8021q/vlan_dev.c - Use print_mac

Joe Perches wrote:
> Perhaps it's more sensible to go back to
> 
> #ifdef DEBUG
> #define pr_debug(fmt, arg...) do {} while (0)
> #endif
> 
> and give up the printf argument verification

I think argument verification is important.   Can you keep it
like this:

#ifdef DEBUG
#define pr_debug(fmt, arg...) \
	do { \
		if (0) \
			printk(KERN_DEBUG fmt, ##arg); \
	} while (0)
#endif

We still lose the return value though, I'm not sure how to keep that
safely in macros.

But does anything rely on the side effects already?  This would
introduce bugs if so.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html