lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Tue, 19 Feb 2008 11:43:44 -0500
From:	Vlad Yasevich <vladislav.yasevich@...com>
To:	Pavel Emelyanov <xemul@...nvz.org>
Cc:	David Miller <davem@...emloft.net>,
	Linux Netdev List <netdev@...r.kernel.org>,
	lksctp-developers@...ts.sourceforge.net
Subject: Re: [Lksctp-developers] [PATCH][SCTP]: Pick up an orphaned	sctp_sockets_allocated
 counter.

Pavel Emelyanov wrote:
> This counter is currently write-only.
> 
> Drawing an analogy with the similar tcp counter, I think
> that this one should be pointed by the sockets_allocated
> members of sctp_prot and sctpv6_prot.
> 
> Or should it be instead removed at all?
> 
> Signed-off-by: Pavel Emelyanov <xemul@...nvz.org>

Ack.  Looks like it got missed.  It should be added.

-vlad

> 
> ---
> 
> diff --git a/net/sctp/socket.c b/net/sctp/socket.c
> index d47d578..44797ad 100644
> --- a/net/sctp/socket.c
> +++ b/net/sctp/socket.c
> @@ -6488,6 +6488,7 @@ struct proto sctp_prot = {
>  	.memory_pressure = &sctp_memory_pressure,
>  	.enter_memory_pressure = sctp_enter_memory_pressure,
>  	.memory_allocated = &sctp_memory_allocated,
> +	.sockets_allocated = &sctp_sockets_allocated,
>  	REF_PROTO_INUSE(sctp)
>  };
>  
> @@ -6521,6 +6522,7 @@ struct proto sctpv6_prot = {
>  	.memory_pressure = &sctp_memory_pressure,
>  	.enter_memory_pressure = sctp_enter_memory_pressure,
>  	.memory_allocated = &sctp_memory_allocated,
> +	.sockets_allocated = &sctp_sockets_allocated,
>  	REF_PROTO_INUSE(sctpv6)
>  };
>  #endif /* defined(CONFIG_IPV6) || defined(CONFIG_IPV6_MODULE) */
> 
> -------------------------------------------------------------------------
> This SF.net email is sponsored by: Microsoft
> Defy all challenges. Microsoft(R) Visual Studio 2008.
> http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
> _______________________________________________
> Lksctp-developers mailing list
> Lksctp-developers@...ts.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/lksctp-developers
> 

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Powered by blists - more mailing lists