netdev - Re: [PATCH] bonding: simplify code and get rid of warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <21522.1203526676@death>
Date:	Wed, 20 Feb 2008 08:57:56 -0800
From:	Jay Vosburgh <fubar@...ibm.com>
To:	Stephen Hemminger <shemminger@...tta.com>
cc:	bonding-devel@...ts.sourceforge.net, netdev@...r.kernel.org
Subject: Re: [PATCH] bonding: simplify code and get rid of warning 

Stephen Hemminger <shemminger@...tta.com> wrote:

>Get rid of warning and simplify code that looks up vlan tag.
>No need to get tag, then copy it. Also no need for a local status
>variable.

	Granted, the current code is suboptimal, but I don't see any
warnings compiling this (gcc 4.1.2).  What are you getting?

	-J

---
	-Jay Vosburgh, IBM Linux Technology Center, fubar@...ibm.com


>Signed-off-by: Stephen Hemminger <shemminger@...tta.com>
>---
>Patch against current 2.6.25 version.
>
>--- a/drivers/net/bonding/bond_alb.c	2008-02-18 20:58:53.000000000 -0800
>+++ b/drivers/net/bonding/bond_alb.c	2008-02-18 21:01:10.000000000 -0800
>@@ -678,12 +678,8 @@ static struct slave *rlb_choose_channel(
> 		}
>
> 		if (!list_empty(&bond->vlan_list)) {
>-			unsigned short vlan_id;
>-			int res = vlan_get_tag(skb, &vlan_id);
>-			if (!res) {
>+			if (!vlan_get_tag(skb, &client_info->vlan_id))
> 				client_info->tag = 1;
>-				client_info->vlan_id = vlan_id;
>-			}
> 		}
>
> 		if (!client_info->assigned) {
>--
>To unsubscribe from this list: send the line "unsubscribe netdev" in
>the body of a message to majordomo@...r.kernel.org
>More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html