netdev - Re: [net-2.6][DRIVER][VETH] fix dev refcount race

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20080220.002210.103312359.davem@davemloft.net>
Date:	Wed, 20 Feb 2008 00:22:10 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	dlezcano@...ibm.com
Cc:	xemul@...nvz.org, netdev@...r.kernel.org
Subject: Re: [net-2.6][DRIVER][VETH] fix dev refcount race

From: Daniel Lezcano <dlezcano@...ibm.com>
Date: Tue, 19 Feb 2008 17:18:00 +0100

> veth: fix dev refcount race
> 
> When deleting the veth driver, veth_close calls netif_carrier_off
> for the two extremities of the network device. netif_carrier_off on
> the peer device will fire an event and hold a reference on the peer
> device. Just after, the peer is unregistered taking the rtnl_lock while
> the linkwatch_event is scheduled. If __linkwatch_run_queue does not
> occurs before the unregistering, unregister_netdevice will wait for
> the dev refcount to reach zero holding the rtnl_lock and linkwatch_event
> will wait for the rtnl_lock and hold the dev refcount.
> 
> Signed-off-by: Daniel Lezcano <dlezcano@...ibm.com>

Thank you for fixing this bug, patch applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html