netdev - Re: New sparse warning in net/mac80211/debugfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1203587699.17534.135.camel@johannes.berg>
Date:	Thu, 21 Feb 2008 10:54:59 +0100
From:	Johannes Berg <johannes@...solutions.net>
To:	Harvey Harrison <harvey.harrison@...il.com>
Cc:	David Miller <davem@...emloft.net>, Joe Perches <joe@...ches.com>,
	linux-netdev <netdev@...r.kernel.org>
Subject: Re: New sparse warning in net/mac80211/debugfs_sta.c


On Thu, 2008-02-21 at 01:34 -0800, Harvey Harrison wrote:
> commit 0795af5729b18218767fab27c44b1384f72dc9ad
> Author: Joe Perches <joe@...ches.com>
> Date:   Wed Oct 3 17:59:30 2007 -0700
> 
>     [NET]: Introduce and use print_mac() and DECLARE_MAC_BUF()
>     
>     This is nicer than the MAC_FMT stuff.
>     
>     Signed-off-by: Joe Perches <joe@...ches.com>
>     Signed-off-by: David S. Miller <davem@...emloft.net>
> 
> Introduced:
> net/mac80211/debugfs_sta.c: In function ‘ieee80211_sta_debugfs_add’:
> net/mac80211/debugfs_sta.c:211: warning: statement with no effect
> 
> Does print_mac modify the mac buffer in-place, or return a new buffer?

It modifies the buffer, and I think it's more likely that the warning
was introduced by

commit 8f789c48448aed74fe1c07af76de8f04adacec7d
Author: David S. Miller <davem@...emloft.net>
Date:   Mon Feb 18 16:50:22 2008 -0800

    [NET]: Elminate spurious print_mac() calls.

since __pure indicates that the function has no side effects apart from
the return value (IIRC)

johannes

Download attachment "signature.asc" of type "application/pgp-signature" (829 bytes)