netdev - Re: New sparse warning in net/mac80211/debugfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20080221.020554.259219477.davem@davemloft.net>
Date:	Thu, 21 Feb 2008 02:05:54 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	harvey.harrison@...il.com
Cc:	joe@...ches.com, netdev@...r.kernel.org
Subject: Re: New sparse warning in net/mac80211/debugfs_sta.c

From: Harvey Harrison <harvey.harrison@...il.com>
Date: Thu, 21 Feb 2008 02:01:19 -0800

> In this case, it's being passed to a debugfs create function, could it
> instead use sysfs_format_mac?

Just assigning print_mac() to a local variable then passing that to
debugfs_create_dir() will make the warning go away.

>From another perspective adding that __pure attribute to print_mac()
might not have been the best idea.  But I can't think of another
way to elimitate the "passing print_mac() args to pr_debug()
still generates calls to print_mac() even when DEBUG is not
defined" problem :-/

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html