lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 21 Feb 2008 17:34:56 +0100 From: Patrick McHardy <kaber@...sh.net> To: Stephen Hemminger <shemminger@...tta.com> CC: Tilman Schmidt <tilman@...p.cc>, Andrew Morton <akpm@...ux-foundation.org>, linux-kernel@...r.kernel.org, netdev@...r.kernel.org, netfilter-devel@...r.kernel.org Subject: Re: 2.6.25-rc2-mm1 - several bugs and a crash Stephen Hemminger wrote: > On Thu, 21 Feb 2008 12:28:50 +0100 > Patrick McHardy <kaber@...sh.net> wrote: > > > >> diff --git a/net/netfilter/nf_conntrack_core.c b/net/netfilter/nf_conntrack_core.c >> index 327e847..b77eb56 100644 >> --- a/net/netfilter/nf_conntrack_core.c >> +++ b/net/netfilter/nf_conntrack_core.c >> @@ -256,13 +256,19 @@ __nf_conntrack_find(const struct nf_conntrack_tuple *tuple) >> struct hlist_node *n; >> unsigned int hash = hash_conntrack(tuple); >> >> + /* Disable BHs the entire time since we normally need to disable them >> + * at least once for the stats anyway. >> + */ >> + local_bh_disable(); >> > > Use rcu_read_lock instead. local_bh_disable() won't work with some of the other forms > of RCU alternatives. > The caller already calls rcu_read_lock(). This is for the per-cpu statistics. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists