netdev - Re: [PATCH] [PS3] gelic wireless driver needs MAC80211 support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200802232050.35157.IvDoorn@gmail.com>
Date:	Sat, 23 Feb 2008 20:50:34 +0100
From:	Ivo van Doorn <ivdoorn@...il.com>
To:	Sebastian Siewior <netdev@...breakpoint.cc>
Cc:	Masakazu Mokuno <mokuno@...sony.co.jp>, jgarzik@...ox.com,
	netdev@...r.kernel.org
Subject: Re: [PATCH] [PS3] gelic wireless driver needs MAC80211 support

On Saturday 23 February 2008, Ivo van Doorn wrote:
> On Saturday 23 February 2008, Sebastian Siewior wrote:
> > so select it.
> > Signed-off-by: Sebastian Siewior <sebastian@...akpoint.cc>
> > ---
> >  drivers/net/Kconfig |    1 +
> >  1 files changed, 1 insertions(+), 0 deletions(-)
> > 
> > diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig
> > index f337800..a116056 100644
> > --- a/drivers/net/Kconfig
> > +++ b/drivers/net/Kconfig
> > @@ -2363,6 +2363,7 @@ config GELIC_NET
> >  config GELIC_WIRELESS
> >         bool "PS3 Wireless support"
> >         depends on GELIC_NET
> > +       select MAC80211
> >         help
> >          This option adds the support for the wireless feature of PS3.
> >          If you have the wireless-less model of PS3 or have no plan to
> 
> Is there any particular reason why this driver is in drivers/net instead
> of drivers/net/wireless (along with all other wireless drivers?
> 
> Additionally, all other mac80211 drivers depend on mac80211 instead
> of selecting it. So I think for consistency it might be better to also
> make this driver depend on it, rather then selecting.

Additionally, what part of the driver actually uses mac80211?
I just browsed to the code, and it seems to work completely without
using mac80211. Instead it seems to work directly by registering a
net_device structure...

Ivo
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html