netdev - Re: [PATCH,RFC] ep93xx_eth: conversion to phylib framework

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20080224112303.GA21025@xi.wantstofly.org>
Date:	Sun, 24 Feb 2008 12:23:03 +0100
From:	Lennert Buytenhek <buytenh@...tstofly.org>
To:	Herbert Valerio Riedel <hvr@....org>
Cc:	Andy Fleming <afleming@...escale.com>, netdev@...r.kernel.org
Subject: Re: [PATCH,RFC] ep93xx_eth: conversion to phylib framework

On Sun, Feb 24, 2008 at 09:21:53AM +0100, Herbert Valerio Riedel wrote:

> > > Currently, the ep93xx_eth driver doesn't care about the PHY state,
> > > but it should, in order to tell the MAC when full duplex operation is
> > > required; failure to do so causes degraded performance on full duplex
> > > links. This patch implements proper PHY handling via the phylib  
> > > framework:
> > >
> > >  - clean up ep93xx_mdio_{read,write} to conform to ep93xx manual
> > >  - convert ep93xx_eth driver to phylib framework
> > >  - set full duplex bit in configuration of MAC when FDX link detected
> > >  - convert to use print_mac()
> > 
> > Looks good to me.  My only comment is that we might want to have  
> > support for checking preamble suppression support in the PHY Lib,  
> > itself.
> > 
> > Acked-by: Andy Fleming <afleming@...escale.com>
> 
> ...as nothing happend for some months now just wondering, what I should
> do next, to get this patch merged upstream :-)

ACK!
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html