[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-Id: <20080223.195723.218310011.davem@davemloft.net>
Date: Sat, 23 Feb 2008 19:57:23 -0800 (PST)
From: David Miller <davem@...emloft.net>
To: xemul@...nvz.org
Cc: netdev@...r.kernel.org, devel@...nvz.org
Subject: Re: [PATCH][NEIGH]: Fix race between neighbor lookup and table's
hash_rnd update.
From: Pavel Emelyanov <xemul@...nvz.org>
Date: Fri, 22 Feb 2008 12:37:03 +0300
> The neigh_hash_grow() may update the tbl->hash_rnd value, which
> is used in all tbl->hash callbacks to calculate the hashval.
>
> Two lookup routines may race with this, since they call the
> ->hash callback without the tbl->lock held. Since the hash_rnd
> is changed with this lock write-locked moving the calls to ->hash
> under this lock read-locked closes this gap.
>
> Signed-off-by: Pavel Emelyanov <xemul@...nvz.org>
Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists