netdev - Re: New sparse warning in net/mac80211/debugfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <47C2AAC8.8020202@trash.net>
Date:	Mon, 25 Feb 2008 12:47:20 +0100
From:	Patrick McHardy <kaber@...sh.net>
To:	David Miller <davem@...emloft.net>
CC:	joe@...ches.com, johannes@...solutions.net,
	harvey.harrison@...il.com, netdev@...r.kernel.org
Subject: Re: New sparse warning in net/mac80211/debugfs_sta.c

David Miller wrote:
> From: Patrick McHardy <kaber@...sh.net>
> Date: Thu, 21 Feb 2008 19:00:03 +0100
>
>   
>> And adds back the overhead of two completely unnecessary
>> function calls to the VLAN fastpath. How about just
>> stopping this idiocy and reverting the appropriate patches
>> to bring back MAC_FMT and use it where appropriate?
>>     
>
> Agreed, I'll do that.
>   

It would be good if Joe could go through the remaining print_mac users
and convert the remaining unintended function calls in fastpaths back
to MAC_FMT. Grepping for "start_xmit" in commit 0795af5729b shows that
at least 10 hard_start_xmit functions are affected and I expect that
some of the changes in the wireless code affect fastpaths as well.


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html