netdev - Re: [PATCH] llc: fix skb size for test responses

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080225140652.GC4022@ghostprotocols.net>
Date:	Mon, 25 Feb 2008 11:06:52 -0300
From:	Arnaldo Carvalho de Melo <acme@...hat.com>
To:	Jim Westfall <jwestfall@...realistic.net>
Cc:	David Miller <davem@...emloft.net>, netdev@...r.kernel.org
Subject: Re: [PATCH] llc: fix skb size for test responses

Em Sun, Feb 24, 2008 at 09:04:21PM -0800, Jim Westfall escreveu:
> David Miller <davem@...emloft.net> wrote [02.24.08]:
> > From: Jim Westfall <jwestfall@...realistic.net>
> > Date: Sun, 24 Feb 2008 11:07:58 -0800
> > 
> > > Hi
> > > 
> > > The llc test command is used for a layer2 ping and contains a variable 
> > > length payload that we must include in the response.  Use the size of the 
> > > received skb as the size of the skb we must allocate to hold the payload. 
> > > 
> > > This resolved an skb_over_panic(), when trying to copy the payload into 
> > > what was a hard coded skb of size 128.
> > > 
> > > Signed-off-by: Jim Westfall <jwestfall@...realistic.net>
> > 
> > Arnaldo, please review Jim's patch, thanks!
> 
> Our of curiosity did you all get my 2nd patch?  
> 
> Subject: [PATCH] llc: dont trust payload size on test cmd
> 
> I sent it a few minutes after this one, but seems like it never made it 
> to the list.  My local smtp shows it was delivered sucussfully to 
> vger.kernel.org.

I got it, but you made a mistake on the To: address:

From: Jim Westfall <jwestfall@...realistic.net>
Subject: [PATCH] llc: dont trust payload size on test cmd
To: "To:netdev"@vger.kernel.org, acme@...stprotocols.net
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html