netdev - Re: [PATCH] tg3: ethtool phys

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1203955980.8232.227.camel@lb-tlvb-eliezer.il.broadcom.com>
Date:	Mon, 25 Feb 2008 18:13:00 +0200
From:	"Eliezer Tamir" <eliezert@...adcom.com>
To:	"Stephen Hemminger" <shemminger@...tta.com>
cc:	"David Miller" <davem@...emloft.net>, mchan@...adcom.com,
	jgarzik@...ox.com, netdev@...r.kernel.org
Subject: Re: [PATCH] tg3: ethtool phys_id default (rev2)

> > Doesn't this mean that ethtool -p will hold the RTNL lock forever?
> > Is this a good idea?
> > 
> > For example on the Red Hat machine I have here if you do:
> > 
> > ethtool -p eth2 100000 &
> > reboot
> > 
> > Various things the shutdown scripts try to do will fail because of the
> > held RTNL lock. in the end the script dies and the machine does not
> > reboot.
> 
> 1. ethtool -p is only used by root to identify interfaces, so in practice
>    this is not a real problem.
> 
> 2. ethtool -p is interruptible, and the reboot process sends a SIGTERM to
>    all processes.


The simple use-case of running ethtool -p eth0 10000 on an ssh console
and them going to the rack and pressing the power button fails.

It seems like the shutdown script dies a long way before it usually
kills all the processes. 

Bringing down NFS, SNMP and several other services fails.
Then things die for being blocked more then 120 seconds and the system
is stuck.




--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html