netdev - Re: New sparse warning in net/mac80211/debugfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 25 Feb 2008 12:14:34 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	johannes@...solutions.net
Cc:	kaber@...sh.net, joe@...ches.com, harvey.harrison@...il.com,
	netdev@...r.kernel.org
Subject: Re: New sparse warning in net/mac80211/debugfs_sta.c

From: Johannes Berg <johannes@...solutions.net>
Date: Mon, 25 Feb 2008 21:05:42 +0100

> 
> On Mon, 2008-02-25 at 20:56 +0100, Johannes Berg wrote:
> > On Mon, 2008-02-25 at 11:52 -0800, David Miller wrote:
> > > From: Johannes Berg <johannes@...solutions.net>
> > > Date: Mon, 25 Feb 2008 10:53:48 +0100
> > > 
> > > > Maybe we should just add a new printf modifier like %M for MAC
> > > > addresses? Then we could use sprintf, snprintf, printk and whatever we
> > > > please without any of the macro stuff...
> > > 
> > > But GCC has no idea what the heck it is and will warn.
> > 
> > No, I actually wondered about that too and finally just tried, it simply
> > ignores it when doing the printf warnings.
> 
> Wait, no, you're right, I had the wrong warning flags enabled :(

Oh well :-/

I really think it's not worth dorking around with this print_mac()
stuff so much like this, let's just take care of the cases that
Patrick mentioned (which need to go back to MAC_FMT because they
are in fast paths) and then leave this alone for a while.

We've already wasted too much time on this.

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html