netdev - Re: [PATCH] [XFRM] Beet: Fix output for ipv6

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200802252231.01021.joakim.koskela@hiit.fi>
Date:	Mon, 25 Feb 2008 22:31:00 +0200
From:	Joakim Koskela <joakim.koskela@...t.fi>
To:	netdev@...r.kernel.org, Herbert Xu <herbert@...dor.apana.org.au>
Subject: Re: [PATCH] [XFRM] Beet: Fix output for ipv6

Hi Herbert, 

Have you had a chance to look this, or are you working on something else for 
it?

On Friday 08 February 2008 18:12, Joakim Koskela wrote:
> Hi,
>
> This patch fixes the ipv6 mode of ipsec beet. It has been using logic
> similar to tunnel mode, making it crash during esp packaging.
>
> Signed-off-by: Joakim Koskela <jookos@...il.com>
> ---
>  net/ipv6/xfrm6_mode_beet.c |    9 ++++++---
>  1 files changed, 6 insertions(+), 3 deletions(-)
>
> diff --git a/net/ipv6/xfrm6_mode_beet.c b/net/ipv6/xfrm6_mode_beet.c
> index 0527d11..0395800 100644
> --- a/net/ipv6/xfrm6_mode_beet.c
> +++ b/net/ipv6/xfrm6_mode_beet.c
> @@ -40,11 +40,14 @@ static void xfrm6_beet_make_header(struct sk_buff *skb)
>  static int xfrm6_beet_output(struct xfrm_state *x, struct sk_buff *skb)
>  {
>  	struct ipv6hdr *top_iph;
> +	u8 *prevhdr;
> +	int hdr_len;
>
> +	hdr_len = x->type->hdr_offset(x, skb, &prevhdr);
> +	skb_set_mac_header(skb, (prevhdr - x->props.header_len) - skb->data);
>  	skb_set_network_header(skb, -x->props.header_len);
> -	skb->mac_header = skb->network_header +
> -			  offsetof(struct ipv6hdr, nexthdr);
> -	skb->transport_header = skb->network_header + sizeof(*top_iph);
> +	skb->transport_header = skb->network_header + hdr_len;
> +	__skb_pull(skb, hdr_len);
>
>  	xfrm6_beet_make_header(skb);
>

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html